Remove the shell extension's dependency on fmt for huge savings #9552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, this one-line change shaves off almost half the binary. Binary size savings (x64 Release): Note | WindowsTerminalShellExt.dll ------ | --------------------------- Before | 130048 After | 73728 Delta | 56320 %Delta | 43.3%
carlos-zamora
approved these changes
Mar 20, 2021
ghost
requested review from
|
This does complete pull fmt from ShellExt Found the waste using @Austin-Lamb’s tools 😄 |
miniksa
approved these changes
Mar 21, 2021
|
ha! |
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Merged
DHowett
added a commit
that referenced
this pull request
Apr 2, 2021
Yeah, this one-line change shaves off almost half the binary. Binary size savings (x64 Release): Note | WindowsTerminalShellExt.dll ------ | --------------------------- Before | 130048 After | 73728 Delta | -56320 %Delta | -43.3% (cherry picked from commit 9069fca)
|
🎉 Handy links: |
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yeah, this one-line change shaves off almost half the binary.
Binary size savings (x64 Release):